-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance class search #484
Enhance class search #484
Conversation
b9d9f74
to
f67886d
Compare
.../src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluationHelpers.scala
Outdated
Show resolved
Hide resolved
.../src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluationHelpers.scala
Outdated
Show resolved
Hide resolved
.../src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluationHelpers.scala
Outdated
Show resolved
Hide resolved
.../src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluationHelpers.scala
Outdated
Show resolved
Hide resolved
d04cda3
to
c44c6db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be easier I think not to stack the PR one on top of the other if there are not directly related.
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/SourceEntrySearchTree.scala
Outdated
Show resolved
Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/SourceLookUpProvider.scala
Outdated
Show resolved
Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/SourceLookUpProvider.scala
Outdated
Show resolved
Hide resolved
.../src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluationHelpers.scala
Outdated
Show resolved
Hide resolved
c44c6db
to
fcd6297
Compare
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/SourceLookUpProvider.scala
Outdated
Show resolved
Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/Validation.scala
Show resolved
Hide resolved
modules/tests/src/test/scala/ch/epfl/scala/debugadapter/internal/RuntimeEvaluatorTests.scala
Outdated
Show resolved
Hide resolved
use transform for pre-evaluation simplify classes indexing
afd3571
to
6fb7848
Compare
I have absolutely no idea of why in Scala 2 there are no breakpoints inside |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last comment :)
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/SourceLookUpProvider.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: adpi2 <adrien.piquerez@gmail.com>
Optimize class search with an index
Allow manipulation of classes with special characters in their name (
+
,&
...)Allow partially qualified class name (e.g.
mutable.Seq
)Also fixes #503